docs: TextButton migration#1088
Merged
georgewrmarshall merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
Contributor
📖 Storybook Preview |
georgewrmarshall
requested changes
Apr 17, 2026
Contributor
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
Component Migration Review: TextButton / ButtonLink
Reviewed against the current mobile ButtonLink implementation and the current DSRN TextButton / Button APIs. I found one blocking documentation issue that should be corrected before merge.
Key Findings
- blocking: Broken relative migration guide link in TextButton README
The rest of the migration guidance looks aligned with the current implementation.
|
|
||
| ## Migration from MetaMask Mobile Component Library | ||
|
|
||
| Migrating from the legacy `ButtonLink` in `app/component-library/components/Buttons/Button/variants/ButtonLink`? See the [TextButton (ButtonLink) migration guide](../../MIGRATION.md#textbutton-component-buttonlink) for the full prop mapping, `label` → `children`, and when to use `Button` with `variant={ButtonVariant.Tertiary}` instead. |
Contributor
There was a problem hiding this comment.
blocking: The relative link target looks incorrect from this file location. ../../MIGRATION.md resolves to src/MIGRATION.md (missing). Can we update this to ../../../MIGRATION.md#textbutton-component-buttonlink so the migration guide link works from the README?
kirillzyusko
force-pushed
the
docs/text-button-migration-p2
branch
from
8ae077a to
b5564ec
Compare
Contributor
📖 Storybook Preview |
georgewrmarshall
previously approved these changes
Apr 20, 2026
kirillzyusko
force-pushed
the
docs/text-button-migration-p2
branch
from
b5564ec to
a11950a
Compare
Contributor
📖 Storybook Preview |
georgewrmarshall
approved these changes
Apr 20, 2026
georgewrmarshall
pushed a commit
that referenced
this pull request
Apr 27, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Added migration docs for `TextButton`. ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-637 ## **Manual testing steps** 1. Open Readme 2. Check migration instructions ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** N/A ### **After** <img width="1055" height="1026" alt="image" src="https://github.com/user-attachments/assets/5ada93b2-5a84-4928-8de3-8fced44924d3" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: documentation-only updates that don’t change runtime behavior. > > **Overview** > Adds a new migration section for replacing legacy Mobile `ButtonLink` with design-system `TextButton`, including prop mappings (notably `label` → `children`), removed props, and guidance on when to use tertiary `Button` instead. > > Updates the `TextButton` README to link to this new migration guide for Mobile consumers. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a11950a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
cursor Bot
pushed a commit
that referenced
this pull request
Apr 28, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Added migration docs for `TextButton`. ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-637 ## **Manual testing steps** 1. Open Readme 2. Check migration instructions ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** N/A ### **After** <img width="1055" height="1026" alt="image" src="https://github.com/user-attachments/assets/5ada93b2-5a84-4928-8de3-8fced44924d3" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: documentation-only updates that don’t change runtime behavior. > > **Overview** > Adds a new migration section for replacing legacy Mobile `ButtonLink` with design-system `TextButton`, including prop mappings (notably `label` → `children`), removed props, and guidance on when to use tertiary `Button` instead. > > Updates the `TextButton` README to link to this new migration guide for Mobile consumers. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a11950a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added migration docs for
TextButton.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-637
Manual testing steps
Screenshots/Recordings
Before
N/A
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: documentation-only updates that don’t change runtime behavior.
Overview
Adds a new migration section for replacing legacy Mobile
ButtonLinkwith design-systemTextButton, including prop mappings (notablylabel→children), removed props, and guidance on when to use tertiaryButtoninstead.Updates the
TextButtonREADME to link to this new migration guide for Mobile consumers.Reviewed by Cursor Bugbot for commit a11950a. Bugbot is set up for automated code reviews on this repo. Configure here.