feat: [DSRN] Added PickerBase#1082
Open
brianacnguyen wants to merge 2 commits intomainfrom
Open
Conversation
Contributor
📖 Storybook Preview |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 34ea187. Configure here.
Contributor
📖 Storybook Preview |
brianacnguyen
commented
Apr 22, 2026
| * PickerBase — trailing arrow direction (maps to platform arrow icons). | ||
| * Convert from enum to const object (ADR-0003). | ||
| */ | ||
| export const PickerBaseEndArrow = { |
Contributor
Author
There was a problem hiding this comment.
PickerEndArrowDirection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds
PickerBaseto@metamask/design-system-react-native: a presentational picker row whose root is aPressable(accessibilityRole="button",accessibilityState/disabledtied toisDisabled). The label usesTextOrChildren(string +textPropsor arbitrarychildren). OptionalstartAccessoryrenders before the label. The trailing slot is either a mapped arrowIconwhenendArrowis set (PickerBaseEndArrow→ArrowUp/ArrowDown/ArrowLeft/ArrowRight), orendAccessorywhenendArrowis omitted; if both are passed,endArrowwins.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-686
Manual testing steps
yarn storybook:iosoryarn storybook:android).endArrowtoup,left,right, andundefined(no arrow); withendArrowcleared, confirmendAccessory-style stories still behave as expected.isDisabledand confirm the control looks disabled and does not fireonPresswhen tapped.yarn workspace @metamask/design-system-react-native jest packages/design-system-react-native/src/components/PickerBase/PickerBase.test.tsx.Screenshots/Recordings
Before
N/A — new component.
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-04-14.at.22.49.31.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: adds a new presentational component with Storybook/docs/tests and only minor export surface changes; no auth, persistence, or business logic changes.
Overview
Adds new
PickerBaseto@metamask/design-system-react-native: aPressablerow with optionalstartAccessory, label viaTextOrChildren/textProps, and a trailing slot that shows a mapped arrow icon viaendArrow(orendAccessorywhen omitted) plus disabled handling (isDisabled).Exports the component and shared types (
PickerBaseEndArrow,PickerBasePropsShared) throughdesign-system-react-nativeanddesign-system-shared, and wires in Storybook stories, Jest coverage, and a newPickerBaseREADME.Reviewed by Cursor Bugbot for commit 624ad78. Bugbot is set up for automated code reviews on this repo. Configure here.