Skip to content

feat(snap-account-service): add SnapAccountService#8414

Merged
ccharly merged 5 commits intomainfrom
cc/feat/snap-account-service
Apr 28, 2026
Merged

feat(snap-account-service): add SnapAccountService#8414
ccharly merged 5 commits intomainfrom
cc/feat/snap-account-service

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Apr 9, 2026

Explanation

A new service where we will move the common logic of the current monolith SnapKeyring.

The idea is to be able to split this keyring into multiple ones and move the KeyringEvents logic in this service.

High-level architecture is the following:

Screenshot 2026-04-09 at 14 49 23

For now, it's just an empty service, but we will move forward with more follow-up change as we are rewriting the existing SnapKeyring to use the new KeyringV2.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk because this PR mainly adds a new, currently no-op package and wires it into repo metadata/build config without changing existing runtime behavior.

Overview
Introduces a new package, @metamask/snap-account-service, scaffolding the SnapAccountService messenger-based service (currently with an empty init() and no exposed actions/events) plus a basic Jest test and package docs.

Wires the new package into monorepo plumbing: adds it to root README package list/dependency graph, CODEOWNERS/teams.json ownership, root tsconfig references, and yarn.lock workspace entry, along with standard package configs (TypeScript, Jest, Typedoc, changelog, license).

Reviewed by Cursor Bugbot for commit 62e982b. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly changed the title feat(snap-account-service): add SnapAccountService feat(snap-account-service): add SnapAccountService Apr 9, 2026
@ccharly ccharly marked this pull request as ready for review April 9, 2026 15:35
@ccharly ccharly requested a review from a team as a code owner April 9, 2026 15:35
@ccharly ccharly enabled auto-merge April 13, 2026 11:59
Comment thread packages/snap-account-service/README.md
Comment thread packages/snap-account-service/src/SnapAccountService.ts
@ccharly ccharly force-pushed the cc/feat/snap-account-service branch from f570e75 to 2963d98 Compare April 14, 2026 11:30
@ccharly ccharly requested a review from a team as a code owner April 14, 2026 11:30
Comment thread packages/keyring-controller/src/KeyringController.ts
@ccharly ccharly force-pushed the cc/feat/snap-account-service branch from 2963d98 to 61675d0 Compare April 15, 2026 12:46
@ccharly ccharly requested review from a team as code owners April 15, 2026 12:46
@ccharly ccharly changed the base branch from main to cc/feat/with-keyrings April 15, 2026 12:49
auto-merge was automatically disabled April 15, 2026 12:49

Merge commits are not allowed on this repository

@ccharly ccharly removed request for a team April 15, 2026 12:49
@ccharly ccharly force-pushed the cc/feat/with-keyrings branch from 0f03c1f to 7fa0b28 Compare April 16, 2026 16:22
@ccharly ccharly requested review from a team as code owners April 17, 2026 17:19
Comment thread packages/snap-account-service/package.json
@ccharly ccharly force-pushed the cc/feat/snap-account-service branch from db372cc to d43c0ee Compare April 17, 2026 17:25
@ccharly ccharly changed the base branch from cc/feat/with-keyrings to main April 17, 2026 17:26
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b06e156. Configure here.

Comment thread packages/snap-account-service/tsconfig.build.json
@ccharly ccharly removed request for a team April 17, 2026 17:34
david0xd
david0xd previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccharly ccharly added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit 6fa9721 Apr 28, 2026
366 checks passed
@ccharly ccharly deleted the cc/feat/snap-account-service branch April 28, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants