Migrated functions using heic2any to heic-convert; Update CSP - #8100
Open
mrafie1 wants to merge 5 commits into
Open
Migrated functions using heic2any to heic-convert; Update CSP#8100mrafie1 wants to merge 5 commits into
mrafie1 wants to merge 5 commits into
Conversation
Collaborator
Coverage Report for CI Build 30707107693Coverage decreased (-0.005%) to 90.498%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In this PR, I updated functions that use
heic2anyto useheic-convert.heic-convertand uninstalledheic2any(no other functions/code required heic2any) inpackage.jsonfilesimage_viewer.jsxto useheic-convertresults_controllerandsubmissions_controllerto not have an exception forunsafe_eval, since MarkUs usesheic-convertinstead ofheic2anycontent_security_policy.rbinformation regardingheic2anyand usages ofunsafe_evalbecause of this packageScreenshots of your changes (if applicable)
In this video:
heicimageheicimageScreen.Recording.2026-07-31.at.20.33.40.mov
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)