Repository navigation
Use take instead of first on pg_locks association - #24032
Merged
agrare merged 1 commit intoOct 23, 2026
Merged
Conversation
pg_locks has no primary key, so Rails has no column to order by when we call first. Rails 8.1 raises ActiveRecord::MissingRequiredOrderError by default in that case. wait_resource only needs any one lock, not a particular one, so take is the right call and works on every Rails version. It worked until now because the default scope preloads the locks, so first never went to the database. Without the preload it fails: VmdbDatabaseConnection.unscoped.first.wait_resource # => ActiveRecord::MissingRequiredOrderError Part of ManageIQ#23946
Member
|
Checked commit jrafanie@8b9e3b6 with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1 |
agrare
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_locks has no primary key, so Rails has no column to order by when we call first. Rails 8.1 raises ActiveRecord::MissingRequiredOrderError by default in that case.
wait_resource only needs any one lock, not a particular one, so take is the right call and works on every Rails version.
It worked until now because the default scope preloads the locks, so first never went to the database. Without the preload it fails:
Part of #23946