Repository navigation
Replace mb_chars.limit with truncate_bytes in format_sync_error - #24000
Merged
Merged
Conversation
jrafanie
force-pushed
the
rails-8-1-deprecation-mb-chars
branch
from
October 6, 2026 19:44
c8eed5f to
92291f8
Compare
Member
|
Checked commit jrafanie@92291f8 with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1 app/models/manageiq/providers/embedded_ansible/automation_manager/configuration_script_source.rb
spec/models/manageiq/providers/embedded_ansible/automation_manager/configuration_script_source_spec.rb
|
String#mb_chars is deprecated in Rails 8.1 and will be removed in 8.2. truncate_bytes(n, omission: nil) is the idiomatic ActiveSupport replacement - available since Rails 6.0 so it works on 8.0 and 8.1 without shims. Part of ManageIQ#23946 (Rails 8.1 deprecation) See also https://www.github.com/rails/rails/pull/54269
jrafanie
force-pushed
the
rails-8-1-deprecation-mb-chars
branch
from
October 7, 2026 20:27
f1b8e8a to
c83bbfa
Compare
agrare
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String#mb_chars is deprecated in Rails 8.1 and will be removed in 8.2. truncate_bytes(n, omission: nil) is the idiomatic ActiveSupport replacement
Part of #23946 (Rails 8.1 deprecation)
See also https://www.github.com/rails/rails/pull/54269