Use default user factory password in specs

[Fryguy]

In ManageIQ/manageiq#23996 password complexity rules are being added, which will fail validation when simple passwords like 'x' or 'smartvm' are passed into user factories.

Using the default password ('dummy') avoids failing the password complexity check while still satisfying the test requirements.

Part of ManageIQ/manageiq#23996. This can be merged independent of the parent PR.

@jrafanie Please review.

[miq-bot]

Checked commit Fryguy@98c2cc1 with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1
3 files checked, 6 offenses detected

spec/requests/auth_spec.rb

• ❗ - Line 36, Col 104 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.
• ❗ - Line 36, Col 51 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
• ❗ - Line 50, Col 104 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.
• ❗ - Line 50, Col 51 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.

spec/requests/restful_redirect_spec.rb

• ❗ - Line 6, Col 102 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.
• ❗ - Line 6, Col 49 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.

[GilbertCherrie]

@Fryguy, I'm wondering when the core PR is merged, if this will cause the user form Cypress tests to fail as it uses password Test-Password-123 and Test-Updated-Password-123, and I am not sure if these meet the minimum complexity score

[Fryguy]

Yes those will fail - let me update those too.

[Fryguy]

@GilbertCherrie I double checked and those passwords are considered strong, so no changed needed.

[GilbertCherrie]

@Fryguy sounds good, this should be fine to merge then

[jrafanie]

Part of ManageIQ/manageiq#23996. This can be merged independent of the parent PR.

👍