add configurable visualizer framerate and optimize cava lifecycle - #897
Open
romanstingler wants to merge 1 commit into
Open
add configurable visualizer framerate and optimize cava lifecycle#897romanstingler wants to merge 1 commit into
romanstingler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix 2/X
related to #895
The media player visualizer now supports a
visualizer_framerateconfigoption (clamped to 1-144, default 30) to control CAVA frame production.
Additionally,
menu_visualizernow only runs cava while the media menu isopen, reducing CPU usage when the menu is closed. The cava subscription
includes the framerate in its identity to ensure proper restart on config
reload, and stale bar frames are cleared when the menu opens.