make add() idempotent and guard run loop against panics - #834
Open
romanstingler wants to merge 1 commit into
Open
make add() idempotent and guard run loop against panics#834romanstingler wants to merge 1 commit into
romanstingler wants to merge 1 commit into
Conversation
Collaborator
|
@romanstingler I might be able to test this well with niri dmps off and on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard against double-Added races in
Outputs::add(): if a live shell already exists for the exact(name, output_id)pair, skip re-creating the layer surface. This prevents needless wgpu surface churn when the compositor re-announces an output while a previous surface is still being torn down.Also wrap the iced run loop in
catch_unwindso wgpu/compositor panics produce a clean logged exit (with backtrace from the existing panic hook) instead of a silent core dump, making systemd restarts reliable.