Skip to content

Dsc refactor p3 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jonavellecuerdo wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Dsc refactor p3 #213

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2a560c1
Refactor project folder structure for improved organization and scala…
jonavellecuerdo Feb 18, 2026
ddafb7f
Introduce abstract base class for transforming metadata
jonavellecuerdo Feb 18, 2026
82234b3
Update Workflow.prepare_batch methods to return ItemSubmission's
jonavellecuerdo Feb 18, 2026
c1975d0
Rename abstract method for preparing batches
jonavellecuerdo Feb 18, 2026
9150813
Move creation of DSpace metadata JSON to batch creation step
jonavellecuerdo Feb 18, 2026
d23cd6e
Align all workflows to use a Transformer for generating Dublin Core m…
jonavellecuerdo Feb 19, 2026
2aaaf2c
Update tests
jonavellecuerdo Feb 18, 2026
6c94f73
Deprecate use of metadata mapping JSON
jonavellecuerdo Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dsc/workflows/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

from dsc.workflows.archivesspace import ArchivesSpace
from dsc.workflows.base import Workflow
from dsc.workflows.base.simple_csv import SimpleCSV
from dsc.workflows.opencourseware import OpenCourseWare
from dsc.workflows.sccs import SCCS
from dsc.workflows.simple_csv import SimpleCSV

__all__ = ["SCCS", "ArchivesSpace", "OpenCourseWare", "SimpleCSV", "Workflow"]
3 changes: 3 additions & 0 deletions dsc/workflows/archivesspace/__init__.py
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@ehanson8 ehanson8 Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a version of this comment that seemed to fall in a black hole so repeating: I really like this organization, the previous approach worked but I appreciate having a workflow's files collocated like this!

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from dsc.workflows.archivesspace.workflow import ArchivesSpace

__all__ = ["ArchivesSpace"]
0 ...flows/metadata_mapping/archivesspace.json → ...flows/archivesspace/metadata_mapping.json
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions dsc/workflows/archivesspace.py → dsc/workflows/archivesspace/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from dsc.db.models import ItemSubmissionStatus
from dsc.item_submission import ItemSubmission
from dsc.workflows.base.simple_csv import SimpleCSV
from dsc.workflows.simple_csv import SimpleCSV

logger = logging.getLogger(__name__)

Expand All @@ -25,7 +25,7 @@ class ArchivesSpace(SimpleCSV):

@property
def metadata_mapping_path(self) -> str:
return "dsc/workflows/metadata_mapping/archivesspace.json"
return "dsc/workflows/archivesspace/metadata_mapping.json"

@property
def output_path(self) -> str:
Expand Down
Loading