Skip to content

Fix for First argument to super() is not enclosing class #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orbeckst wants to merge 1 commit into from
+1 −1
Closed

Fix for First argument to super() is not enclosing class #5418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package/MDAnalysis/analysis/dihedrals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ def __init__(
:attr:`angles` results are now stored in a
:class:`MDAnalysis.analysis.base.Results` instance.
"""
super(Ramachandran, self).__init__(

@orbeckst orbeckst Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks horrible but is actually correct.

AnalysisBase's init is special so I also need to change the arguments when calling Ramachandran.

@orbeckst orbeckst Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally, Janin does not want to call Ramachandran's init; it's a bit of a mess

super(Janin, self).__init__(
atomgroup.universe.trajectory, **kwargs
)
self.atomgroup = atomgroup
Expand Down
Loading