Skip to content

fix: preserve authentication limits in fallback composition - #16

Merged
Lucenx9 merged 1 commit into
mainfrom
fix/authentication-rate-limit-fallback
Aug 14, 2026
Merged

fix: preserve authentication limits in fallback composition#16
Lucenx9 merged 1 commit into
mainfrom
fix/authentication-rate-limit-fallback

Conversation

@Lucenx9

@Lucenx9 Lucenx9 commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

Preserves the configured authentication rate-limit defaults when application composition is invoked without an explicit rate-limit policy.

The fallback previously reused the API-key burst of 30 for authentication, while loadConfig() defines an authentication burst of 60. This caused authentication-heavy E2E flows to receive an unintended 429 RATE_LIMITED response.

Changes

  • add the missing 600 requests/minute and burst-60 authentication fallback values;
  • add a composition regression test that sends 61 valid-format unknown credentials and proves 60 authentication attempts are evaluated before the 61st is rate-limited;
  • preserve the existing account/API-key limits and burst.

Validation

  • regression test: red at 30 × 401 / 31 × 429 before the production fix; green at 60 × 401 / 1 × 429 after it;
  • GitHub-ingestion E2E in isolation: 3 passed;
  • complete E2E grouping: 92 passed;
  • full bounded offline suite: 651 passed, 7 expected environment-gated skips, 0 failures;
  • formatting, ESLint, strict typecheck, build, migrations (including idempotent rerun), catalog and advisory verification passed;
  • git diff --check passed.

@Lucenx9
Lucenx9 merged commit d7d5fcc into main Aug 14, 2026
6 checks passed
@Lucenx9
Lucenx9 deleted the fix/authentication-rate-limit-fallback branch August 14, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant