Use linear space in multiclass stats computation when n_classes>1000#3342
Open
barakugav wants to merge 1 commit intoLightning-AI:masterfrom
Open
Use linear space in multiclass stats computation when n_classes>1000#3342barakugav wants to merge 1 commit intoLightning-AI:masterfrom
barakugav wants to merge 1 commit intoLightning-AI:masterfrom
Conversation
barakugav
requested review from
SkafteNicki,
justusschock and
lantiga
as code owners
barakugav
force-pushed
the
multiclass-many
branch
from
c610c46 to
85c5135
Compare
barakugav
force-pushed
the
multiclass-many
branch
from
85c5135 to
c3835f2
Compare
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (31%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #3342 +/- ##
========================================
- Coverage 37% 31% -6%
========================================
Files 364 349 -15
Lines 20096 19906 -190
========================================
- Hits 7521 6169 -1352
- Misses 12575 13737 +1162 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #3343
The PR changes multi-class accuracy to work with large number of classes, by changing its computation to use a linear amount of memory instead of quadratic.
The quadratic space is needed for the full confusion matrix, but for accuracy alone it is not required.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
📚 Documentation preview 📚: https://torchmetrics--3342.org.readthedocs.build/en/3342/