New Metric: Upper Face Dynamics Deviation(FDD)#3238
Open
VijayVignesh1 wants to merge 46 commits intoLightning-AI:masterfrom
Open
New Metric: Upper Face Dynamics Deviation(FDD)#3238VijayVignesh1 wants to merge 46 commits intoLightning-AI:masterfrom
VijayVignesh1 wants to merge 46 commits intoLightning-AI:masterfrom
Conversation
f48ea3c to
2a74503
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3238 +/- ##
======================================
- Coverage 37% 36% -0%
======================================
Files 349 351 +2
Lines 19901 19973 +72
======================================
+ Hits 7264 7288 +24
- Misses 12637 12685 +48 🚀 New features to boost your workflow:
|
Borda
reviewed
Sep 5, 2025
45752a3 to
12cc909
Compare
rittik9
reviewed
Sep 9, 2025
Contributor
Author
|
@Borda The unittest error seems to coming from a timeout error from azure's end. Unrelated to the code. |
rittik9
reviewed
Sep 13, 2025
rittik9
reviewed
Sep 13, 2025
rittik9
reviewed
Sep 13, 2025
rittik9
reviewed
Sep 13, 2025
rittik9
reviewed
Sep 13, 2025
rittik9
reviewed
Sep 13, 2025
rittik9
reviewed
Sep 13, 2025
rittik9
reviewed
Sep 13, 2025
rittik9
reviewed
Sep 13, 2025
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds the Upper Face Dynamics Deviation (FDD) metric for evaluating 3D talking head upper-face motion, including functional and class APIs, documentation, and tests.
- Introduces functional API upper_face_dynamics_deviation and class UpperFaceDynamicsDeviation
- Wires exports, adds docs and plotting test coverage, and updates changelog
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/torchmetrics/functional/multimodal/fdd.py | Adds the functional FDD computation and docstring |
| src/torchmetrics/multimodal/fdd.py | Adds the metric class implementation and plotting support |
| src/torchmetrics/functional/multimodal/init.py | Exposes the new functional |
| src/torchmetrics/multimodal/init.py | Exposes the new metric class |
| src/torchmetrics/functional/init.py | Re-exports the functional at top-level |
| tests/unittests/multimodal/test_fdd.py | Adds unit tests for class, functional, errors, differentiability, and plotting |
| tests/unittests/utilities/test_plot.py | Adds the metric to generic plot tests |
| docs/source/multimodal/fdd.rst | Adds user-facing docs for the metric |
| docs/source/links.rst | Adds reference link for FDD |
| CHANGELOG.md | Notes the new metric addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fdb763f to
b3496d6
Compare
rittik9
approved these changes
Oct 3, 2025
Correcting typos and mistakes in doctrings Co-authored-by: Copilot <[email protected]>
… device agnostic test implementation and correcting docstring mistakes
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
e7d3421 to
44a4530
Compare
justusschock
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the Upper Face Dynamics Deviation (FDD) metric for 3D talking head evaluation.
Computes the deviation in motion magnitude of upper-face vertices between predicted and ground truth meshes.
Fixes #3097
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3238.org.readthedocs.build/en/3238/