Skip to content

Update Litlogger Integration to latest version#21591

Merged
tchaton merged 3 commits intomasterfrom
update_litlogger_internals
Mar 19, 2026
Merged

Update Litlogger Integration to latest version#21591
tchaton merged 3 commits intomasterfrom
update_litlogger_internals

Conversation

@justusschock
Copy link
Copy Markdown
Member

@justusschock justusschock commented Mar 19, 2026

What does this PR do?

Upgrades the litlogger integration, it's internals, the tests and the required version to the latest litlogger.

These unittests just make sure we call the correct APIs, full integration tests against the released version as well as the development version will live in the litlogger repo

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21591.org.readthedocs.build/en/21591/

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/litlogger.py, tests/tests_pytorch/loggers/conftest.py, tests/tests_pytorch/loggers/test_litlogger.py.

🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, pytorch, 3.10) success
pytorch.yml / Lit Job (lightning, 3.12) success
pytorch.yml / Lit Job (pytorch, 3.12) success

These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/litlogger.py, tests/tests_pytorch/loggers/conftest.py, tests/tests_pytorch/loggers/test_litlogger.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success
benchmark.yml / Lit Job (pytorch) success

These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/litlogger.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/loggers/litlogger.py, requirements/pytorch/loggers.info.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/litlogger.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/loggers/litlogger.py, requirements/pytorch/loggers.info.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 77.04918% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79%. Comparing base (283ce77) to head (884ffa1).
⚠️ Report is 16 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (283ce77) and HEAD (884ffa1). Click for more details.

HEAD has 2452 uploads less than BASE
Flag BASE (283ce77) HEAD (884ffa1)
cpu 590 42
python 54 3
lightning_fabric 159 0
pytest 294 0
lightning 269 15
python3.11 107 6
python3.12 160 12
python3.10 54 3
python3.13 54 9
python3.12.7 161 9
pytorch2.3 27 3
pytest-full 296 42
pytorch2.2.2 26 3
pytorch_lightning 162 27
pytorch2.6 27 3
pytorch2.1 54 6
pytorch2.9 27 6
pytorch2.5.1 27 3
pytorch2.8 54 6
pytorch2.4.1 27 3
pytorch2.7 27 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21591     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       24078    24036     -42     
=========================================
- Hits        20863    18963   -1900     
- Misses       3215     5073   +1858     

@tchaton tchaton merged commit 1690c21 into master Mar 19, 2026
98 checks passed
@tchaton tchaton deleted the update_litlogger_internals branch March 19, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants