workflows: report failing package and patch in build-failure notifications - #149
Open
heitbaum wants to merge 2 commits into
Open
workflows: report failing package and patch in build-failure notifications#149heitbaum wants to merge 2 commits into
heitbaum wants to merge 2 commits into
Conversation
…tions The failure-reason extraction used grep -ohE, which discarded everything except the matched keyword, so every notification collapsed to a bare "APPLY PATCH" (or CONFIGURE/CMAKE/UNPACK) with no indication of which package or patch actually failed. A kodi patch failing during the JsonSchemaBuilder:host step was reported only as "APPLY PATCH". Strip the ANSI colour codes first, then derive the reason as the failing phase plus the package being unpacked (the last UNPACK marker), and for patch failures append the failing patch path. The kodi case now reads: reason for failure - APPLY PATCH kodi (projects/Amlogic/patches/kodi/0001-workaround-for-subs-on-lima.patch) Applied to the make-image and create-addon workflows for LE10 to LE13.
Pass DISABLE_COLORS=yes to the build so captured logs are plain text, which also makes the uploaded failed-build logs far easier to read. With colour codes gone the failure-reason extraction no longer needs to strip ANSI escapes first, so parse the log directly. Applied to the make-image and create-addon workflows for LE10 to LE13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure-reason extraction used grep -ohE, which discarded everything except the matched keyword, so every notification collapsed to a bare "APPLY PATCH" (or CONFIGURE/CMAKE/UNPACK) with no indication of which package or patch actually failed. A kodi patch failing during the JsonSchemaBuilder:host step was reported only as "APPLY PATCH".
Strip the ANSI colour codes first, then derive the reason as the failing phase plus the package being unpacked (the last UNPACK marker), and for patch failures append the failing patch path. The kodi case now reads: