fix(video): correct video upload protocol via highway#111
Open
linyuchen wants to merge 1 commit into
Open
Conversation
Three issues prevent video upload from working end-to-end:
- BuildFileInfo for VideoEntity dereferences info.Type which is never
initialized. Replace info.Type.Type = 2 with
info.Type = new FileType { Type = 2 }.
- Group / C2C highway command IDs are swapped: group video uses 1005/1006
and C2C uses 1001/1002, not the other way around. With the wrong cmd
the server acks all blocks but archives to the wrong storage bucket,
so the recipient cannot resolve the file URL.
- Thumbnail upload was missing the sha1 recomputation that the main
video has. GenerateExt fills hash.FileSha1 from main video's index,
Preprocess overwrites it with CalculateStreamBytes for main but not
for thumb, so the thumb upload sends bytes paired with the wrong sha1
list. Server accepts the bytes but the thumb stays unbound to the
message and the recipient sees no cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
附上 ffmpeg 生成随机 150-200MB 的视频命令