-
Notifications
You must be signed in to change notification settings - Fork 6
Add support for custom code generators #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LM-robynka
merged 13 commits into
main
from
issue-65-add-support-for-custom-code-generators
Oct 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e0ed68c
add command line arg to use custom code generator instead of default
LM-robynka dfc94e2
improvements
LM-robynka 5e5401c
respond to comments
LM-robynka e782dc6
add tests and exception handling
LM-robynka 28f4596
remove debug print
LM-robynka d9cc229
include .py files for testing
LM-robynka 9788e20
add some more error handling
LM-robynka 08cab8b
fix test after improving executeCustomGenerator
LM-robynka 7b35225
correct custom_genfile param in DumpFile so that tests pass correctly
LM-robynka 19e0c69
improve tests
LM-robynka f6e8fdb
remove return type from executeCustomGenerator
LM-robynka 057a5e3
update test to reflect changes to return type of executeCustomGenerator
LM-robynka f8347b7
cleanup
LM-robynka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,26 @@ | ||
| """Tests for node.py""" | ||
| import pytest | ||
| import os | ||
|
|
||
| from objdictgen.node import Node | ||
| from objdictgen.node import Node, NodeProtocol, executeCustomGenerator | ||
|
|
||
| @pytest.mark.parametrize("file", ['master', 'slave']) | ||
| def test_node_LoadFile(odpath, file): | ||
|
|
||
| od = Node.LoadFile(odpath / (file + '.json')) | ||
| assert isinstance(od, Node) | ||
| assert od.Name == 'master' if file == 'master' else 'slave' | ||
|
|
||
| @pytest.mark.parametrize("filename", ["this_file_does_not_exist.py", "bad_generator.py", "generator.py"]) | ||
| def test_node_execute_custom_generator(filename: str): | ||
| print(os.getcwd()) | ||
| full_path = "tests/test_generators/" | ||
| mock_path = "/mock" | ||
|
LM-robynka marked this conversation as resolved.
|
||
| if filename == "bad_generator.py": | ||
| with pytest.raises(AttributeError): | ||
| executeCustomGenerator(full_path + filename, mock_path, NodeProtocol) | ||
| elif filename == "this_file_does_not_exist.py": | ||
| with pytest.raises(FileNotFoundError): | ||
| executeCustomGenerator(full_path + filename, mock_path, NodeProtocol) | ||
| elif filename == "generator.py": | ||
| assert executeCustomGenerator(full_path + filename, mock_path, NodeProtocol) == "success" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.