Repository navigation
Conversation
TheRDavid
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The selector must use stable advertisement data/name or retain the default selector instead of matching the original peripheral UUID.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
This pull request connects a custom peripheral selector to the iOS/MacCatalyst DFU initiator.
Changes:
- Assigns
DfuPeripheralSelectorDelegatetoPeripheralSelector. - Adjusts closing-brace formatting.
| File | Summary |
|---|---|
Laerdal.Dfu/Platforms.iOSandMacCatalyst/DfuInstallation.cs |
Registers the custom selector; its UUID matching can reject the bootloader peripheral and stall DFU. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Logger = new DfuLogger(), | ||
| WeakDelegate = DfuServiceDelegate, | ||
| WeakProgressDelegate = DfuProgressDelegate, | ||
| PeripheralSelector = DfuPeripheralSelectorDelegate, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change in 2-6 lines.
Why
Explain the reason for this change.
Change Type
refa)Affected Areas
Laerdal.Dfu)Platforms.Droid)Platforms.iOSandMacCatalyst)Platforms.NetX)Behavior And Compatibility
If any box above is checked, describe impact:
Platform Notes
List platform-specific behavior differences introduced or touched (Android/iOS/MacCatalyst).
Tests
Validation notes:
Documentation
Risks And Follow-ups
Risk level:
Known limitations or deferred follow-ups:
Checklist
type(scope): short imperativeand is <= 72 chars