LibGfx+LibWeb: Use per-code-point font fallback for SVG text - #11228
Open
sideshowbarker wants to merge 2 commits into
Open
LibGfx+LibWeb: Use per-code-point font fallback for SVG text#11228sideshowbarker wants to merge 2 commits into
sideshowbarker wants to merge 2 commits into
Conversation
Problem: Characters a generic font doesn’t cover drew as missing-glyph boxes inside SVG text; e.g. U+1D11E with font-family:serif — while the same character renders correctly in ordinary HTML text, and naming a font that does cover it renders it correctly inside SVG as well. Cause: The SVG text path builder resolved one font for a whole run with first_available_font() — the first font in the list that covers the space character — and then handed the entire string to Skia to map through that font alone. So any code point outside it became glyph 0. Fix: Shape each run with Gfx::shape_text() against the box’s full font list — the same way HTML text and canvas text already did. Fixes LadybirdBrowser#11031
After SVG text path-building was reworked to build from shaped glyph runs, Path::text() and place_text_along() no longer have any callers.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (11)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughLibGfx replaces UTF-8 and UTF-16 text placement APIs with glyph-run placement APIs. The Skia backend transforms glyph outlines along paths using glyph positions, widths, and path tangents. SVG layout now shapes text with the complete font list for fallback support, uses glyph runs for measurement and rendering, and places them along paths. Layout expectations and SVG font-fallback tests were updated. Sequence Diagram(s)sequenceDiagram
participant SVGLayout
participant GfxShapeText
participant PathSkia
SVGLayout->>GfxShapeText: Shape text with the font list
GfxShapeText-->>SVGLayout: Return glyph runs
SVGLayout->>PathSkia: Place glyph runs along the path
PathSkia-->>SVGLayout: Return transformed glyph outlines
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Characters a generic font doesn’t cover drew as missing-glyph boxes inside SVG text; e.g. U+1D11E with
font-family:serif— while the same character renders correctly in ordinary HTML text, and naming a font that does cover it renders it correctly inside SVG as well.Cause: The SVG text path builder resolved one font for a whole run with
first_available_font()— the first font in the list that covers the space character — and then handed the entire string to Skia to map through that font alone. So any code point outside it became glyph 0.Fix: Shape each run with
Gfx::shape_text()against the box’s full font list — the same way HTML text and canvas text already did. Fixes #11031.Note
This PR branch contains two commits: The first commit has the change described above, while the second commit is entirely just deletions of the
Path::text()andplace_text_along()code — which no longer has any callers, after the change to usingGfx::shape_text()against the box’s full font list.So, it might be easier to first review the first commit in isolation, and then review the deletions.