LibWeb: Include strut descent below inline-block baselines - #11150
Merged
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (49)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe change extends line-box strut alignment to inline-blocks and inline flex containers for vertical-align keywords. It adds inline-block strut descent geometry coverage. It updates layout, paint-tree, stacking-context, display-list, reference, and cache expectations for the resulting fractional heights and positions. Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep the containing block strut descent below a baseline-aligned inline-block when that box raises the line baseline. This preserves the minimum depth required by line-height and advances wrapped lines from the corrected line-box end. Add deterministic coverage for empty and text-bearing inline-blocks, wrapped content, and the overflow baseline fallback. Rebaseline affected layout and screenshot expectations.
awesomekling
force-pushed
the
mushthing
branch
from
August 16, 2026 07:58
1c5e30f to
0736ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the containing block strut descent below a baseline-aligned inline-block when that box raises the line baseline. This preserves the minimum depth required by line-height and advances wrapped lines from the corrected line-box end.
Add deterministic coverage for empty and text-bearing inline-blocks, wrapped content, and the overflow baseline fallback. Rebaseline affected layout and screenshot expectations.