LibWeb: Bound the inline ancestor walks at the containing block - #11053
Merged
kalenikaliaksandr merged 1 commit intoAug 9, 2026
Merged
Conversation
The fragmented-inline-ancestor lookup and the piece-inset chain accumulation walked ancestor chains that terminate only at the first non-inline ancestor or the tree root. Both chains describe state owned by the current inline formatting context, so they must not leave its subtree: when the containing block is itself inline-level with flow inside (an inline list-item root), the old walks could cross into the enclosing context's boxes. Both walks now stop at the containing block.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe inline formatting context now stops ancestor traversal at its containing block. This applies to fragmented inline ancestor lookup and relative inset accumulation. ChangesInline formatting context boundaries
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kalenikaliaksandr
merged commit Aug 9, 2026
f0226a2
into
LadybirdBrowser:master
14 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fragmented-inline-ancestor lookup and the piece-inset chain accumulation walked ancestor chains that terminate only at the first non-inline ancestor or the tree root. Both chains describe state owned by the current inline formatting context, so they must not leave its subtree: when the containing block is itself inline-level with flow inside (an inline list-item root), the old walks could cross into the enclosing context's boxes. Both walks now stop at the containing block.