Skip to content

LibGfx: Include all contours in PathImplSkia::length() #11049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmta merged 1 commit into from
Aug 9, 2026
+16 −1
Merged

LibGfx: Include all contours in PathImplSkia::length() #11049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Libraries/LibGfx/PathSkia.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,11 @@ Gfx::FloatRect PathImplSkia::bounding_box() const
float PathImplSkia::length() const
{
SkPathMeasure path_measure(sk_path(), false);
return path_measure.getLength();
float length = 0;
do {
length += path_measure.getLength();
} while (path_measure.nextContour());
return length;
}

bool PathImplSkia::contains(FloatPoint point, Gfx::WindingRule winding_rule) const
Expand Down
1 change: 1 addition & 0 deletions Tests/LibWeb/Text/expected/SVG/svg-path-get-total-length-multiple-subpaths.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
120
10 changes: 10 additions & 0 deletions Tests/LibWeb/Text/input/SVG/svg-path-get-total-length-multiple-subpaths.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!doctype html>
<script src="../include.js"></script>
<svg xmlns="http://www.w3.org/2000/svg">
<path id="path" d="M0 0 h 10 v 10 H 0 z M 20 0 h 20 v 20 H 20 z" />
</svg>
<script>
test(() => {
println(document.getElementById("path").getTotalLength());
});
</script>