Skip to content

Replace the layout engine style decode layer with lazy CV views #10961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalenikaliaksandr merged 10 commits into from
Aug 1, 2026
Merged

Replace the layout engine style decode layer with lazy CV views #10961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
61a6275
LibWeb: Add lazy length-percentage views over computed style payloads
kalenikaliaksandr Aug 1, 2026
382b67d
LibWeb: Read sizing properties straight from the style group payloads
kalenikaliaksandr Aug 1, 2026
91378ac
LibWeb: Read margins and paddings straight from the surround payload
kalenikaliaksandr Aug 1, 2026
4d3209d
LibWeb: Model inset reads as a typed value instead of a decoded struct
kalenikaliaksandr Aug 1, 2026
a2587b4
LibWeb: Read gaps, SVG geometry and offsets through payload views
kalenikaliaksandr Aug 1, 2026
62ac9d7
LibWeb: Carry grid track sizes as payload references, drop FfiSizeValue
kalenikaliaksandr Aug 1, 2026
ee7524e
LibWeb: Drop the migration allowance from the computed value views
kalenikaliaksandr Aug 1, 2026
536bea7
LibWeb: Fold StyleReader into StyleValues
kalenikaliaksandr Aug 1, 2026
51b7243
LibWeb: Move the computed style accessor surface into the css module
kalenikaliaksandr Aug 1, 2026
29c76c0
LibWeb: Generate the plain payload projections through accessor macros
kalenikaliaksandr Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Libraries/LibWeb/Rust/src/css/computed_value_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ pub enum ComputedSizeKind {
/// immutable Rust style-value identity. Fit-content retains only its
/// argument, and keyword-only forms leave the handle empty.
#[repr(C)]
#[derive(Debug)]
pub struct ComputedStyleValueHandle {
pub pointer: *const std::ffi::c_void,
}

#[repr(C)]
#[derive(Debug)]
pub struct ComputedSize {
pub kind: ComputedSizeKind,
pub value: ComputedStyleValueHandle,
Expand Down Expand Up @@ -367,3 +369,18 @@ pub struct SVGResetValues {
pub vector_effect: u8,
pub shape_rendering: u8,
}

// Registered indices of the style groups the computed-values view reads,
// pinned to the C++ StyleGroupIndex enum by static_asserts in
// LayoutRustBridge.cpp.
pub const STYLE_GROUP_INDEX_INHERITED_TABLE: usize = 0;
pub const STYLE_GROUP_INDEX_GRID: usize = 9;
pub const STYLE_GROUP_INDEX_INHERITED_TEXT: usize = 4;
pub const STYLE_GROUP_INDEX_INHERITED_BOX: usize = 5;
pub const STYLE_GROUP_INDEX_FONT: usize = 6;
pub const STYLE_GROUP_INDEX_SVG_RESET: usize = 8;
pub const STYLE_GROUP_INDEX_BORDER: usize = 17;
pub const STYLE_GROUP_INDEX_ALIGNMENT: usize = 18;
pub const STYLE_GROUP_INDEX_SIZING: usize = 20;
pub const STYLE_GROUP_INDEX_SURROUND: usize = 21;
pub const STYLE_GROUP_INDEX_BOX: usize = 22;
Loading
Loading