LibWeb: Move anonymous text run filtering to Rust - #10926
Merged
kalenikaliaksandr merged 1 commit intoJul 29, 2026
Merged
Conversation
The flex and grid item collection paths crossed into C++ to identify anonymous boxes containing only untransformed ASCII whitespace after node topology and text content had moved into the Rust arena. Record the pre-transform whitespace classification during existing text synchronization, evaluate the predicate directly from arena node data in Rust, and remove the formatting-context callback. The separate fact keeps TextNode::text() behavior when rendered text differs after transformation or first-letter slicing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe change moves anonymous whitespace text-run detection into Rust. Text nodes now synchronize an ASCII-whitespace flag into the layout arena, and flex/grid formatting contexts use a Rust predicate instead of a C++ callback. ChangesAnonymous text-run handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant TextNode
participant LayoutNodeArena
participant FlexOrGridFormattingContext
participant FfiLayoutFcCallbacks
TextNode->>LayoutNodeArena: synchronize text and ASCII-whitespace flag
FlexOrGridFormattingContext->>FfiLayoutFcCallbacks: check anonymous text run
FfiLayoutFcCallbacks->>LayoutNodeArena: inspect node and child text metadata
LayoutNodeArena-->>FfiLayoutFcCallbacks: return stored whitespace data
FfiLayoutFcCallbacks-->>FlexOrGridFormattingContext: return skip decision
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Comment |
kalenikaliaksandr
merged commit Jul 29, 2026
1a85ae8
into
LadybirdBrowser:master
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flex and grid item collection paths crossed into C++ to identify anonymous boxes containing only untransformed ASCII whitespace after node topology and text content had moved into the Rust arena.
Record the pre-transform whitespace classification during existing text synchronization, evaluate the predicate directly from arena node data in Rust, and remove the formatting-context callback. The separate fact keeps TextNode::text() behavior when rendered text differs after transformation or first-letter slicing.