Implement theme toggle#421
Draft
headquarter8302 wants to merge 1 commit intoLMMS:masterfrom
Draft
Conversation
headquarter8302
added
enhancement
help wanted
design
php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to close #420 (nice) by implementing a theme toggle in the global site nav. This toggle will be powered by JS to set an arbitrary body class to override the CSS colors, eventually deprecating the
light-darklogical unit in favor of a super-class.The preference will be stored in a long-living private cookie, which can be easily cleared by the user by clearing their cookie jar or deleting their browsing history