Autoplacer,block-size: Consider resource group properties for initial min-IO size#480
Open
chrstnwhlrt wants to merge 1 commit intoLINBIT:masterfrom
Open
Autoplacer,block-size: Consider resource group properties for initial min-IO size#480chrstnwhlrt wants to merge 1 commit intoLINBIT:masterfrom
chrstnwhlrt wants to merge 1 commit intoLINBIT:masterfrom
Conversation
Contributor
|
Thanks for the contribution.
Afterwards we can merge this PR internally, so it will be included in the next release. Even in this case we will need to close this PR, but will of course keep you as committer + author. Do you want me to make the small changes or do you want to amend your commit? |
0509fb9 to
5a5fbda
Compare
Author
|
@ghernadi I made the requested adjustments, let me know if you need anything else |
Contributor
|
We pushed our internal master to here on GitHub. Please rebase your PR since at least a constant changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When auto-block-size determines the initial block-size for a new volume definition, it only considers the storage pool's hardware min-IO size. If the resource group or volume group has a larger DrbdOptions/Disk/block-size configured, it is ignored because the volume definition is created with empty properties and rscMinIoSizeCheck() only reads from the volume definition directly.
This causes problems on clusters with mixed sector sizes (e.g. 512-byte and 4096-byte disks): the autoplacer picks nodes with the most free space (typically the 512-byte nodes), sets block-size=512 on the volume definition, and then later adding a 4096-byte node fails with "incompatible minimum I/O size" - even though block-size=4096 is explicitly configured on the resource group.
Fix by consulting the PriorityProps hierarchy (resource definition, volume group, resource group) when initially setting the block-size, and using max(pool min-IO size, configured block-size) as the effective value.