Skip to content

netcom: Fix NPE in establishConnection when peer is null #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrstnwhlrt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

netcom: Fix NPE in establishConnection when peer is null #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions server/src/main/java/com/linbit/linstor/netcom/TcpConnectorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,7 +997,7 @@ protected void establishConnection(SelectionKey currentKey)
String localAddrText = null;
String remoteAddrText = null;

try
if (localAddr instanceof InetSocketAddress)
{
final InetSocketAddress localInetAddr = (InetSocketAddress) localAddr;
final InetAddress ipAddress = localInetAddr.getAddress();
Expand All @@ -1006,12 +1006,8 @@ protected void establishConnection(SelectionKey currentKey)
localAddrText = ipAddress.getHostAddress();
}
}
catch (ClassCastException ignored)
{
// ignored
}

try
if (remoteAddr instanceof InetSocketAddress)
{
final InetSocketAddress remoteInetAddr = (InetSocketAddress) remoteAddr;
final InetAddress ipAddress = remoteInetAddr.getAddress();
Expand All @@ -1020,10 +1016,6 @@ protected void establishConnection(SelectionKey currentKey)
remoteAddrText = ipAddress.getHostAddress();
}
}
catch (ClassCastException ignored)
{
// ignored
}

final String errorDescription =
this.getServiceName() + " connector: Connection " +
Expand Down