Repository navigation
Clear the SSH agent identity when the shell prompt clock changes - #1064
Merged
Merged
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested official Pebrel 2.6.0 on InstaBox with a real OpenSSH shell, Codex CLI 0.160.0, hooks disabled, and an isolated provider. With a fixed Bash prompt the agent identity cleared within one second. With a clock in the prompt, when the exit crossed a second boundary, the shell could execute a new command while Pebrel still reported Codex after ten seconds.
The prompt matcher accepts a changed bracketed 24-hour clock when the original and returned shell prompts have the same remote host and marker. Tests reject a changed host, a typed command, an invalid time and a removed clock. A GPUI test checks the agent identity and sidebar state after a hookless Codex exit. A standalone comparison using the production matcher failed on the base and passed after the fix. Local formatting and architecture checks passed.
Related to #1059. The report does not include the user's prompt format.