Repository navigation
Keep an earlier worker reply from completing a new delegation - #1061
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A worker could finish an earlier turn while its next delegated prompt was queued. Pebrel then returned the earlier answer and discarded the new task. The runtime now checks the worker at registration and again in the UI update that writes the prompt. Only hooks received since that write can complete the task. A timed-out client can cancel a queued write, and a write failure releases the worker.
Adapted from @yjjheizhu's #919. The regression exercises busy and replaced workers, a delayed completion across submission, a timeout on either side of the write, and a failed write followed by another delegation. Both desktop adapters use the same submission check. Local architecture, formatting and diff checks passed. Native tests run in CI. The preceding callback change is tracked by #1060.