Skip to content

Close the originally confirmed busy tab after tab order changes - #1056

Merged
Kuddev merged 5 commits into
mainfrom
fix/codex-tab-close-target-1120
Nov 20, 2026
Merged

Kuddev merged 5 commits into
mainfrom
fix/codex-tab-close-target-1120

Conversation

@Kuddev

@Kuddev Kuddev commented Nov 20, 2026

Copy link
Copy Markdown
Owner

A busy tab can move or exit while its close dialog is open. Looking up the old position on confirmation can close a neighbour and leave the intended Codex tab in the next workspace snapshot.

Resolve the original tab ID or pane ID when the confirmation arrives. A target that has already left the window makes the confirmation a no-op.

The GPUI regression opens the dialog, removes the preceding tab or the target, confirms, and inspects the surviving workspace. Local architecture, formatting and diff checks passed.

@github-actions github-actions Bot added the size/S ≤100 行源码改动 label Nov 20, 2026
@github-actions github-actions Bot added size/M 101–500 行 and removed size/S ≤100 行源码改动 labels Nov 20, 2026
@Kuddev
Kuddev merged commit d607120 into main Nov 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M 101–500 行

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant