Repository navigation
docs(platform): verify domain ownership before attaching custom domains - #55
Conversation
|
|
|
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
shawnwu-kong
left a comment
shawnwu-kong
left a comment
There was a problem hiding this comment.
Reviewed the domain verification instructions against CLI #278 and Hosting #1648. No blocking findings. Retain the documented release order: merge once a CLI release includes the new domain commands.
# Conflicts: # AGENTS.md
Managed TLS entries for an unowned hostname deploy and wait for the _volcano record, which 'volcano cloud frontends domain get' lists; only BYOC attaches fail with the record. Note that 'volcano cloud domains' needs an account login.
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Teaches agents the custom-domain ownership flow: a frontend serves a custom domain only once the account has verified that hostname or a domain above it with a DNS TXT record.
volcano-platform/SKILL.md: a "Custom domains (cloud only)" section coveringvolcano cloud domains verify|list, relaying the exact record the CLI prints (only the user can publish DNS), and how each TLS mode reacts to an unverified hostname: a BYOC attach (domain createortls.mode: byoc) fails with the record, while atls.mode: managedentry deploys, holds the hostname, and lists the record involcano cloud frontends domain get. Notes thatvolcano cloud domainsneeds avolcano loginsession.AGENTS.md: addsvolcano cloud domainsto the command surface, andverify/removeto the confirm-first account changes.Commands, flags, and output were checked against volcano-cli v0.43.2 (
internal/cmd/domains,internal/api/errors.go,internal/output/frontends.go) and the managed/BYOC behavior against volcano-hosting v0.29.0 (internal/frontenddomains,docs/public/frontends/domain-verification.md).node scripts/check-skills.mjsandnode --test tests/cli-setup.test.mjspass.Order
The prerequisite has shipped: the commands come from volcano-cli v0.42.0 (Kong/volcano-cli#278), and the platform API from Kong/volcano-hosting#1648 is live in staging and production (v0.29.0).
🤖 Generated with Claude Code