Skip to content

fix: hard code typo in CONTRIBUTING md - #1

Merged
shawnwu-kong merged 1 commit into
mainfrom
shawn.wu/fix-hardcode-typo
Jun 30, 2026
Merged

shawnwu-kong merged 1 commit into
mainfrom
shawn.wu/fix-hardcode-typo

Conversation

@shawnwu-kong

Copy link
Copy Markdown
Contributor

fix one tiny typo

@shawnwu-kong
shawnwu-kong requested a review from tkkhq June 30, 2026 20:58
@CLAassistant

CLAassistant commented Jun 30, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tkkhq tkkhq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Replacing the hardcoded /Users/ted.kim/... path with $(git rev-parse --show-toplevel) is a genuine portability improvement — strictly better than the machine-specific path. Minor note: it now assumes the snippet is run from inside the repo (empty SRC if run outside a checkout), but that's reasonable for a contributor-facing pre-release check.

@shawnwu-kong
shawnwu-kong merged commit 12928d8 into main Jun 30, 2026
4 checks passed
tkkhq pushed a commit that referenced this pull request Jun 30, 2026
@shawnwu-kong
shawnwu-kong deleted the shawn.wu/fix-hardcode-typo branch June 30, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants