Shared WebGL context render window by PaulHax · Pull Request #3453 · Kitware/vtk-js

PaulHax · 2026-03-26T03:22:50Z

Are folks intersted in putting this in the vtk.js repo? Its an uncommon use case. We could get away with simply doing something to keep vtkOpenGLRenderWindow from resizing the canvas and put SharedRenderWindow in another repo/package.

Context

This PR adds an OpenGL shared-context rendering path for vtk.js so it can render into a WebGL2RenderingContext owned by another library, instead of always creating and managing its own canvas/context.

The immediate use case is interleaving vtk.js content with host renderers such as MapLibre custom layers, including depth-tested rendering into the host scene. vtk.js also needs an explicit way to opt out of canvas DOM management when the canvas is externally owned.

Results

Before this change:

vtkOpenGLRenderWindow assumed ownership of the canvas and could resize/restyle it.

After this change:

vtk.js can render into a host-owned WebGL2 context through vtkSharedRenderWindow.createFromContext(canvas, gl).

Changes

Added manageCanvas to vtkOpenGLRenderWindow (default true) so externally owned canvases can opt out of vtk.js canvas sizing/styling.
Added vtkSharedRenderWindow for rendering into an externally provided WebGL2RenderingContext.
Added vtkSharedRenderer for the shared-context rendering path.
Scoped the vtkSharedRenderer override to the shared render-window instance rather than changing the global OpenGL view-node factory. This avoids leaking shared-context behavior into unrelated normal OpenGL render windows.
Added a MapLibre example showing shared-context rendering on terrain.
Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

semantic-release commit messages
Run npm run reformat to have correctly formatted code

Testing

npm run example -- SharedContext

This change adds or fixes unit tests
Tested environment:
- OS: Linux
- Browser: Chrome

finetjul

@sankhesh I do not have any opinion on the approach, I leave it to you.

daker · 2026-03-26T09:01:10Z

@sedghi do you have an opnion on this ?

Copilot

Pull request overview

This PR adds a shared-WebGL2-context rendering path to vtk.js, enabling vtk.js to render into an externally owned WebGL2RenderingContext (e.g., MapLibre custom layers) rather than always creating/managing its own canvas/context.

Changes:

Added manageCanvas (default true) to vtkOpenGLRenderWindow to allow opting out of canvas resizing/styling when the canvas is externally owned.
Introduced vtkSharedRenderWindow.createFromContext(canvas, gl) plus vtkSharedRenderer to support shared-context rendering while keeping overrides local to the shared render-window instance.
Added SharedRenderWindow unit tests (GL state reset, host framebuffer rendering, host survival) and a MapLibre shared-context example.

Reviewed changes

Copilot reviewed 9 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Sources/Rendering/SceneGraph/ViewNodeFactory/index.js	Switches override lookup to support prototype-inherited mappings (`in`), enabling per-instance override chains.
Sources/Rendering/OpenGL/ViewNodeFactory/index.js	Makes OpenGL view-node mappings inheritable per factory instance via `Object.create(CLASS_MAPPING)` and adds instance-local `registerOverride`.
Sources/Rendering/OpenGL/RenderWindow/index.js	Adds `manageCanvas` gating for canvas size/display updates and blocks resize-based screenshot capture when canvas management is disabled.
Sources/Rendering/OpenGL/RenderWindow/index.d.ts	Exposes `manageCanvas` in initial values and adds `getManageCanvas` / `setManageCanvas`.
Sources/Rendering/OpenGL/SharedRenderWindow/index.js	New shared-context render window with GL-state reset, size sync from drawing buffer, and render-callback integration.
Sources/Rendering/OpenGL/SharedRenderWindow/index.d.ts	Type definitions for `vtkSharedRenderWindow` API (renderShared, callbacks, autoClear controls, createFromContext).
Sources/Rendering/OpenGL/SharedRenderer/index.js	New renderer variant that respects shared-window autoClear behavior and uses tiled viewport/scissor.
Sources/Rendering/OpenGL/SharedRenderer/index.d.ts	Type definitions for `vtkSharedRenderer`.
Sources/Rendering/OpenGL/SharedRenderWindow/test/testSharedRenderWindow.js	Baseline image test + validation that shared renderer override remains local + WebGL1 rejection + manageCanvas behavior.
Sources/Rendering/OpenGL/SharedRenderWindow/test/testSharedRenderWindowGLState.js	Tests that `renderShared()` resets GL state and renders into a currently bound host framebuffer.
Sources/Rendering/OpenGL/SharedRenderWindow/test/testSharedRenderWindowHostSurvival.js	Tests host rendering can resume after `renderShared()` when host state is rebound.
Examples/Rendering/SharedContext/index.js	MapLibre terrain example demonstrating shared-context depth-tested interleaving.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sankhesh

LGTM overall.

sankhesh · 2026-05-07T18:28:44Z

+
+function getDefaultDrawBuffers(gl) {
+  const framebuffer = gl.getParameter(gl.FRAMEBUFFER_BINDING);
+  return framebuffer ? [gl.COLOR_ATTACHMENT0] : [gl.BACK];


This is an assumption here. If the external application has bound multiple FBO attachments, assuming attachment 0 might be wrong.

Updated to query DRAW_BUFFER0 to gl.MAX_DRAW_BUFFERS and respect the host's actual draw-buffer state, with [COLOR_ATTACHMENT0] as a fallback when every slot is NONE.

Move registerOverride from extend() into the main function body for both ViewNodeFactory and SharedRenderWindow.

Gate the screenshot-path canvas display toggle on manageCanvas, matching the existing guard at line 164 so externally owned canvases are never restyled. In getDefaultDrawBuffers, query the host's actual DRAW_BUFFER0..N state when an FBO is bound rather than assuming COLOR_ATTACHMENT0. Falls back to [COLOR_ATTACHMENT0] when all slots are NONE so callers that left the default state untouched still get a valid render target.

The SharedRenderWindow tests and type defs predated the Vite/Vitest tooling migration on master. Adapt them so the PR builds and tests cleanly on current master: - migrate the 3 test files from the removed tape harness to Vitest: test.onlyIfWebGL -> it.skipIf(__VTK_TEST_NO_WEBGL__), t.ok/notOk/equal/deepEqual/throws -> expect assertions, drop t.end() (the image-comparison test returns its promise) - update compareImages() to its current (no tape arg) signature - createSharedWindow helper no longer takes a tape handle - reformat index.d.ts with oxfmt (interface extends clause)

PaulHax force-pushed the shared-render-window branch 2 times, most recently from 93f4a3a to 5e23b91 Compare March 26, 2026 03:29

finetjul reviewed Mar 26, 2026

View reviewed changes

Comment thread Sources/Rendering/OpenGL/ViewNodeFactory/index.js Outdated

finetjul requested a review from sankhesh March 26, 2026 15:39

PaulHax force-pushed the shared-render-window branch 5 times, most recently from ca02f1f to 8ed472d Compare April 8, 2026 15:23

PaulHax requested a review from Copilot May 7, 2026 15:01

Copilot started reviewing on behalf of PaulHax May 7, 2026 15:02 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread Sources/Rendering/OpenGL/SharedRenderWindow/index.js

Comment thread Sources/Rendering/OpenGL/SharedRenderWindow/test/testSharedRenderWindowHostSurvival.js

Comment thread Sources/Rendering/OpenGL/SharedRenderWindow/test/testSharedRenderWindowHostSurvival.js

PaulHax force-pushed the shared-render-window branch 4 times, most recently from c19dc9c to 5d1f87a Compare May 7, 2026 16:58

sankhesh reviewed May 7, 2026

View reviewed changes

PaulHax force-pushed the shared-render-window branch 3 times, most recently from dc92777 to db65e08 Compare May 9, 2026 17:44

finetjul added this pull request to the merge queue May 22, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 22, 2026

PaulHax added 5 commits May 22, 2026 12:27

feat(RenderWindow): add manageCanvas for externally owned canvases

b120563

feat: add SharedRenderWindow for external WebGL2 context sharing

84ffb0a

refactor: move method definitions into function bodies

28f17db

Move registerOverride from extend() into the main function body for both ViewNodeFactory and SharedRenderWindow.

PaulHax force-pushed the shared-render-window branch from db65e08 to adf58ff Compare May 22, 2026 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Shared WebGL context render window#3453

Shared WebGL context render window#3453
PaulHax wants to merge 5 commits into
Kitware:masterfrom
PaulHax:shared-render-window

PaulHax commented Mar 26, 2026 •

edited

Loading

Uh oh!

finetjul left a comment

Uh oh!

Uh oh!

daker commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sankhesh left a comment

Uh oh!

Uh oh!

sankhesh May 7, 2026

Uh oh!

PaulHax May 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

PaulHax commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Results

Changes

PR and Code Checklist

Testing

Uh oh!

finetjul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daker commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sankhesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sankhesh May 7, 2026

Choose a reason for hiding this comment

Uh oh!

PaulHax May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

PaulHax commented Mar 26, 2026 •

edited

Loading