Fix for issue #4197#4198
Merged
arcady-lunarg merged 1 commit intoKhronosGroup:mainfrom Apr 28, 2026
Merged
Conversation
|
|
Contributor
|
Please sign the CLA. We can't land your code without it. And thank you. |
Contributor
Author
Sorry, I missed that this was required, I have now signed it. Thanks for the ping. |
arcady-lunarg
requested changes
Apr 25, 2026
Contributor
arcady-lunarg
left a comment
arcady-lunarg
left a comment
There was a problem hiding this comment.
@ErikHogeman You will need to add your new test to one of the lists in gtests/Spv.FromFile.cpp so that it actually gets run.
Change-Id: Icca07eb85ba5692675dfa6eec9fcd48cb38c0333
Contributor
Author
Thanks, not sure how I missed that. Fixed now. |
arcady-lunarg
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update access chain handling to be compatible with raw descriptor heap accesses.