Repository navigation
Profile checker Android app - #1036
Conversation
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
|
8db411b to
9d6c676
Compare
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
christophe-lunarg
left a comment
There was a problem hiding this comment.
I created this PR: #1037
to capture the data changes, the limitype tweaks and doubled checked what was submitted.
Still work in progress...
I'll continue on this tomorrow.
|
|
||
| # Unsupported | ||
| PropertyRequirement('VkPhysicalDeviceMaintenance7PropertiesKHR', 'robustFragmentShadingRateAttachmentAccess', 'false', 'VkPhysicalDeviceMaintenance7FeaturesKHR::maintenance7'), | ||
| PropertyRequirement('VkPhysicalDeviceMaintenance7PropertiesKHR', 'robustFragmentShadingRateAttachmentAccess', None, 'VkPhysicalDeviceMaintenance7FeaturesKHR::maintenance7'), |
There was a problem hiding this comment.
I believe the value was reverted here. The limitype is "max".
| PropertyRequirement('VkPhysicalDeviceRayTracingPipelinePropertiesKHR', 'maxShaderGroupStride', '4096', None), | ||
| PropertyRequirement('VkPhysicalDeviceRayTracingPipelinePropertiesKHR', 'shaderGroupBaseAlignment', '64', None), | ||
| PropertyRequirement('VkPhysicalDeviceRayTracingPipelinePropertiesKHR', 'shaderGroupHandleCaptureReplaySize', '64', None), | ||
| PropertyRequirement('VkPhysicalDeviceRayTracingPipelinePropertiesKHR', 'shaderGroupBaseAlignment', None, None), |
There was a problem hiding this comment.
Here it's a limitype problem in vk.xml. The spec says 'max' and provide the value 64.
| PropertyRequirement('VkPhysicalDeviceRayTracingPipelinePropertiesKHR', 'shaderGroupBaseAlignment', '64', None), | ||
| PropertyRequirement('VkPhysicalDeviceRayTracingPipelinePropertiesKHR', 'shaderGroupHandleCaptureReplaySize', '64', None), | ||
| PropertyRequirement('VkPhysicalDeviceRayTracingPipelinePropertiesKHR', 'shaderGroupBaseAlignment', None, None), | ||
| PropertyRequirement('VkPhysicalDeviceRayTracingPipelinePropertiesKHR', 'shaderGroupHandleCaptureReplaySize', None, None), |
There was a problem hiding this comment.
Same as: shaderGroupBaseAlignment
| PropertyRequirement('VkPhysicalDeviceFragmentShadingRatePropertiesKHR', 'maxFragmentSize', '2, 2', None), | ||
| PropertyRequirement('VkPhysicalDeviceFragmentShadingRatePropertiesKHR', 'maxFragmentSizeAspectRatio', '2', None), | ||
| PropertyRequirement('VkPhysicalDeviceFragmentShadingRatePropertiesKHR', 'maxFragmentShadingRateCoverageSamples', '16', None), | ||
| PropertyRequirement('VkPhysicalDeviceFragmentShadingRatePropertiesKHR', 'maxFragmentShadingRateRasterizationSamples', 'VK_SAMPLE_COUNT_1_BIT', None), |
There was a problem hiding this comment.
maxFragmentShadingRateRasterizationSamples is VK_SAMPLE_COUNT_4_BIT in the spec
| PropertyRequirement('VkPhysicalDeviceDescriptorBufferPropertiesEXT', 'imageViewCaptureReplayDescriptorDataSize', '64', 'VkPhysicalDeviceDescriptorBufferFeaturesEXT::descriptorBuffer'), | ||
| PropertyRequirement('VkPhysicalDeviceDescriptorBufferPropertiesEXT', 'samplerCaptureReplayDescriptorDataSize', '64', 'VkPhysicalDeviceDescriptorBufferFeaturesEXT::descriptorBuffer'), | ||
| PropertyRequirement('VkPhysicalDeviceDescriptorBufferPropertiesEXT', 'accelerationStructureCaptureReplayDescriptorDataSize', '64', 'VkPhysicalDeviceDescriptorBufferFeaturesEXT::descriptorBuffer'), | ||
| PropertyRequirement('VkPhysicalDeviceDescriptorBufferPropertiesEXT', 'descriptorBufferOffsetAlignment', None, 'VkPhysicalDeviceDescriptorBufferFeaturesEXT::descriptorBuffer'), |
There was a problem hiding this comment.
in the spec descriptorBufferOffsetAlignment is set to "max" but I believe it translates into 'min,pot' in vk.xml
| PropertyRequirement('VkPhysicalDeviceDescriptorBufferPropertiesEXT', 'samplerCaptureReplayDescriptorDataSize', '64', 'VkPhysicalDeviceDescriptorBufferFeaturesEXT::descriptorBuffer'), | ||
| PropertyRequirement('VkPhysicalDeviceDescriptorBufferPropertiesEXT', 'accelerationStructureCaptureReplayDescriptorDataSize', '64', 'VkPhysicalDeviceDescriptorBufferFeaturesEXT::descriptorBuffer'), | ||
| PropertyRequirement('VkPhysicalDeviceDescriptorBufferPropertiesEXT', 'descriptorBufferOffsetAlignment', None, 'VkPhysicalDeviceDescriptorBufferFeaturesEXT::descriptorBuffer'), | ||
| PropertyRequirement('VkPhysicalDeviceDescriptorBufferPropertiesEXT', 'bufferCaptureReplayDescriptorDataSize', None, 'VkPhysicalDeviceDescriptorBufferFeaturesEXT::descriptorBuffer'), |
There was a problem hiding this comment.
The spec set it to max 64 and I believe the issue is that vk.xml set is to noauto but in vk.xml is should be "min".
Same for all the "DataSize" member os this structure.
| PropertyRequirement('VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT', 'advancedBlendNonPremultipliedDstColor', 'true', None), | ||
| PropertyRequirement('VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT', 'advancedBlendCorrelatedOverlap', 'true', None), | ||
| PropertyRequirement('VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT', 'advancedBlendAllOperations', 'true', None), | ||
| PropertyRequirement('VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT', 'advancedBlendIndependentBlend', None, None), |
There was a problem hiding this comment.
The issue here is that the default properties for VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT should be false.
The spec says "platform-dependent" but vk.xml says "max" which I believe is correct, it's capabilities that are supported or not.
| "lineSubPixelPrecisionBits": 4, | ||
| "maxVertexAttribDivisor": 2147483647, | ||
| "maxVertexAttribDivisor": 65535, | ||
| "supportsNonZeroFirstInstance": true, |
There was a problem hiding this comment.
supportsNonZeroFirstInstance should be false.
|
I would encourage you to rebase with main branch to grab the changes from #1037. Feel free to comment about values that you think are incorrect. I believe there are still some work to do on the data but this is a great step up. I'll continue working on this. |
|
Sure, I will rebase and try to check if the app works well without any of my changes to scripts. |
9d6c676 to
8c0ac5b
Compare
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
8c0ac5b to
8f9d2fd
Compare
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
8f9d2fd to
187775b
Compare
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
User cgopinathc not on autobuild list. Waiting for curator authorization before starting CI build. |
|
I ran the internal C.I. test just to be sure I am not missing something, it passes so merging. |

No description provided.