spirv-as: Fix OpConstantDataKHR new grammar#6642
Merged
alan-baker merged 1 commit intoApr 17, 2026
Merged
Conversation
spencer-lunarg
force-pushed
the
spencer-lunarg-wtf-did-we-ship
branch
from
9f9c8ed to
01c5c48
Compare
dneto0
previously requested changes
Apr 16, 2026
spencer-lunarg
force-pushed
the
spencer-lunarg-wtf-did-we-ship
branch
from
01c5c48 to
35573b6
Compare
alan-baker
approved these changes
Apr 17, 2026
spencer-lunarg
dismissed
dneto0’s stale review
Talked to David (and others) at F2F about this, we hashed it out, but want to get this in to unblock CTS (which needs the new grammar) and David is traveling back right now
alan-baker
pushed a commit
that referenced
this pull request
Apr 18, 2026
(based on #6642) adds the missing validation for `OpConstantDataKHR`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talked to David at F2F and we decided for now, to just get a fix in to
OpConstantDataKHRfrom KhronosGroup/SPIRV-Headers@ad9184ein the future, we can apply the "joy to use"
UTFEncodedKHRdecoration to allowspirv-as/spirv-disto handle strings