Remove redundant iterations from inliner passes#6639
Merged
s-perron merged 3 commits intoApr 27, 2026
Conversation
|
|
…iner having a potential stale reference by not updating parent for blocks. Fix for opaque inliner not fixing debug declares like exhaustive pass.
Jmangles
force-pushed
the
jrobinson/inliner-optimization
branch
from
5fba3a6 to
23c92f6
Compare
s-perron
approved these changes
Apr 24, 2026
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
This seems reasonable. I'm trying to think of any situation where the previous instruction could be invalidated. I don't think it can.
Collaborator
|
I think the smoke test failures were because you branch was behind. I push changes to merge the latest main. I also ran clang-format to fix the formatting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented in both the exhaustive/opaque inliner even though it appears the opaque one is not fully functional.
In my benchmark tests I found it reduced the time needed to run the exhaustive pass by 50% on average with the shaders I was testing with.
Also fixes two bugs in the opaque inliner. One is from not updating the parent of each new block and the other for debug. These could be split into another PR if desired but it's still pretty small overall.