WIP: [cmake] better shared/static splitting, enable static-only builds#6350
Closed
crueter wants to merge 2 commits intoKhronosGroup:mainfrom
Closed
WIP: [cmake] better shared/static splitting, enable static-only builds#6350crueter wants to merge 2 commits intoKhronosGroup:mainfrom
crueter wants to merge 2 commits intoKhronosGroup:mainfrom
Conversation
Firstly this allows for static-ONLY builds (no shared libs at all)--useful for including this as a subproject Makes the library itself build once via an object library--this isn't actually ideal due to symbol export shenanigans, but this is pretty trivial to solve in code (I just don't feel like it for now) Also makes the shared/static handling for spirv-tools targets just better in general to account for this TODO: - Should we make the other libraries static/shared split? - Fix symbol exporting and cxx visibility nonsense (this isn't even a problem--current code makes it needlessly complex) - test on Windows Signed-off-by: crueter <crueter@eden-emu.dev>
|
|
Author
|
Gonna split this up into 2 PRs soon and fix a bunch of issues with it |
Author
|
sup. #6481 A separate PR will be made for the object-library portion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is super WIP and is largely untested outside of using it as a subproject on Linux.
Firstly this allows for static-ONLY builds (no shared libs at all)--useful for including this as a subproject
Makes the library itself build once via an object library--this isn't actually ideal due to symbol export shenanigans, but this is pretty trivial to solve in code (I just don't feel like it for now)
Also makes the shared/static handling for spirv-tools targets just better in general to account for this
TODO:
See #3909
side note: please allow us to contribute in places other than GitHub--no, that companies-only GitLab doesn't count. two-way mirrors on a Khronos Forgejo would be nice, for example