Update wonder-blocks skill with forms guidance#3452
Conversation
🗄️ Schema Change: No Changes ✅ |
npm Snapshot: NOT PublishedOh noes!! We couldn't find any changesets in this PR (4375315). As a result, we did not |
🛠️ Item Splitting: No Changes ✅ |
|
Size Change: 0 B Total Size: 495 kB ℹ️ View Unchanged
|
544e976 to
8447cc9
Compare
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Do you think there’s a risk that agents following the form doc will assume they should use WB RadioGroup/Choice when working on exercise/widget UI, or otherwise conflate “app forms” with “Perseus widgets”? |
| @@ -0,0 +1,2 @@ | |||
| --- | |||
There was a problem hiding this comment.
All PRs in Perseus require a changeset file. If they touch dev-only infra (like this PR) we just create an empty PR using pnpm changeset --empty.
…heckboxgroup when working on forms and to use perseus components when working on exercises or widgets
@anakaren-rojas Great question! I added some guidance around this in 4375315: perseus/.agents/skills/wonder-blocks/references/forms.md Lines 19 to 20 in 4375315 Let me know if there is more Perseus specific guidance you'd like to add around when it should/shouldn't use wb form components vs perseus components! |
anakaren-rojas
left a comment
There was a problem hiding this comment.
LGTM, thanks so much @beaesguerra !
jandrade
left a comment
There was a problem hiding this comment.
Looks great from the WB perspective! 🚀
Summary:
Updating the wonder-blocks skill in perseus based on the recent updates to the skill in frontend (frontend wb skills with forms reference PR)
In these changes, we add guidance around forms best practices from WB. Form guidance is added as a reference in the WB skill so it should only be loaded for form related changes!
We've updated the docs around forms in WB too: https://khan.github.io/wonder-blocks/?path=/docs/packages-form-overview--docs (changes were in PR: Khan/wonder-blocks#2988)
Issue: FEI-7615
Test plan: