Skip to content

Update wonder-blocks skill with forms guidance#3452

Merged
beaesguerra merged 3 commits intomainfrom
update-wb-skill-with-form-guidance
Apr 8, 2026
Merged

Update wonder-blocks skill with forms guidance#3452
beaesguerra merged 3 commits intomainfrom
update-wb-skill-with-form-guidance

Conversation

@beaesguerra
Copy link
Copy Markdown
Member

@beaesguerra beaesguerra commented Apr 2, 2026

Summary:

Updating the wonder-blocks skill in perseus based on the recent updates to the skill in frontend (frontend wb skills with forms reference PR)

In these changes, we add guidance around forms best practices from WB. Form guidance is added as a reference in the WB skill so it should only be loaded for form related changes!

We've updated the docs around forms in WB too: https://khan.github.io/wonder-blocks/?path=/docs/packages-form-overview--docs (changes were in PR: Khan/wonder-blocks#2988)

Issue: FEI-7615

Test plan:

  1. Try a prompt for building a form. It should load the wonder-blocks skill, then the forms.md reference!
❯ Please create a widget that takes in preference settings. It should include Favourite book, favourite long quote,         
favourite color from (red, yellow, blue options), favourite subject (from math, science, english). Only implement the ui,   
no need to wire it up with backend calls yet. Make favourite book required, favourite long quote minimum 5 characters.      

⏺ Skill(wonder-blocks)
  ⎿  Successfully loaded skill

⏺ Read(/Users/beaesguerra/khan/perseus/.claude/skills/wonder-blocks/references/forms.md)
  ⎿  Read 369 lines

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🗄️ Schema Change: No Changes ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

npm Snapshot: NOT Published

Oh noes!! We couldn't find any changesets in this PR (4375315). As a result, we did not
publish an npm snapshot for you.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🛠️ Item Splitting: No Changes ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Size Change: 0 B

Total Size: 495 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.5 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 6.21 kB
packages/math-input/dist/es/index.js 98.5 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 11.9 kB
packages/perseus-core/dist/es/index.js 25.1 kB
packages/perseus-editor/dist/es/index.js 102 kB
packages/perseus-linter/dist/es/index.js 9.3 kB
packages/perseus-score/dist/es/index.js 9.66 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/index.js 193 kB
packages/perseus/dist/es/strings.js 8.09 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.71 kB

compressed-size-action

@beaesguerra beaesguerra force-pushed the update-wb-skill-with-form-guidance branch from 544e976 to 8447cc9 Compare April 2, 2026 21:18
@beaesguerra beaesguerra marked this pull request as ready for review April 2, 2026 21:28
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@beaesguerra beaesguerra requested review from a team, Myranae and mark-fitzgerald April 2, 2026 21:29
@anakaren-rojas
Copy link
Copy Markdown
Contributor

Do you think there’s a risk that agents following the form doc will assume they should use WB RadioGroup/Choice when working on exercise/widget UI, or otherwise conflate “app forms” with “Perseus widgets”?

Copy link
Copy Markdown
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@@ -0,0 +1,2 @@
---
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this needed?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All PRs in Perseus require a changeset file. If they touch dev-only infra (like this PR) we just create an empty PR using pnpm changeset --empty.

…heckboxgroup when working on forms and to use perseus components when working on exercises or widgets
@beaesguerra
Copy link
Copy Markdown
Member Author

Do you think there’s a risk that agents following the form doc will assume they should use WB RadioGroup/Choice when working on exercise/widget UI, or otherwise conflate “app forms” with “Perseus widgets”?

@anakaren-rojas Great question! I added some guidance around this in 4375315:

- Only use `RadioGroup`/`CheckboxGroup` and `Choice` when working on forms. Use
`perseus` components when working on UI related to exercises or widgets.

Let me know if there is more Perseus specific guidance you'd like to add around when it should/shouldn't use wb form components vs perseus components!

Copy link
Copy Markdown
Contributor

@anakaren-rojas anakaren-rojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much @beaesguerra !

Copy link
Copy Markdown
Member

@jandrade jandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from the WB perspective! 🚀

@beaesguerra beaesguerra merged commit 020e0ae into main Apr 8, 2026
11 checks passed
@beaesguerra beaesguerra deleted the update-wb-skill-with-form-guidance branch April 8, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants