[ Interactive Graph | Vector Graph ] PR5: Editor Support#3443
Draft
SonicScrewdriver wants to merge 2 commits intoLEMS-3971/vector-pr4from
Draft
[ Interactive Graph | Vector Graph ] PR5: Editor Support#3443SonicScrewdriver wants to merge 2 commits intoLEMS-3971/vector-pr4from
SonicScrewdriver wants to merge 2 commits intoLEMS-3971/vector-pr4from
Conversation
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +61 B (+0.01%) Total Size: 496 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (506e43b) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3443If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3443If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3443 |
567ed2e to
3186d72
Compare
2cfe6fe to
3ecf3c6
Compare
3186d72 to
37f9aa6
Compare
3ecf3c6 to
f55af8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR was created with the help of AI, albeit with heavy oversight and review.
This is part of a series of PRs implementing the vector graph type for the Interactive Graph widget:
PR1 – type definitions and schema
▶️ PR5 – editor support (this PR)
PR2 – state management
PR3 – rendering & accessibility
PR4 – scoring
Issue: LEMS-3971
Changes:
interactive-graph-vectorfeature flag.{type: "vector"}toGraphTypesThatHaveStartCoordsunion.getVectorCoordsand addscase "vector"ingetDefaultGraphStartCoords.case "vector"dispatching to<StartCoordsLine>(reuses the existing component since vector has the sameCollinearTupleshape as ray/linear).withVector()builder method andVectorGraphConfigclass to the editor's test data builder.vectorMinimalQuestiontest fixture for the editor story.InteractiveGraphVectoreditor Storybook story.Design decisions:
StartCoordsLine— Vector'sCollinearTuplestart coords shape matches ray/linear, so no custom start coords component is needed (unlike exponential which has an asymptote field).Test plan:
pnpm tsc— no new type errorspnpm lint— no lint errors