[ Interactive Graph | Vector Graph ] PR4: Scoring#3442
Draft
SonicScrewdriver wants to merge 1 commit intoLEMS-3971/vector-pr3from
Draft
[ Interactive Graph | Vector Graph ] PR4: Scoring#3442SonicScrewdriver wants to merge 1 commit intoLEMS-3971/vector-pr3from
SonicScrewdriver wants to merge 1 commit intoLEMS-3971/vector-pr3from
Conversation
… Interactive Graphs
SonicScrewdriver
changed the title
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
|
Size Change: +34 B (+0.01%) Total Size: 496 kB
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (567ed2e) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3442If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3442If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR was created with the help of AI, albeit with heavy oversight and review.
This is part of a series of PRs implementing the vector graph type for the Interactive Graph widget:
PR1 – type definitions and schema
▶️ PR4 – scoring (this PR)
PR2 – state management
PR3 – rendering & accessibility
PR5 – editor support
Issue: LEMS-3971
Changes:
coords[0]) and tip (coords[1]) must match exactly viaapproximateDeepEqual. Unlike ray (which usescollinearfor the second point), vector scoring is order-sensitive — swapping tail and tip is incorrect.Test plan:
pnpm tsc— no new type errorspnpm test packages/perseus-score/src/widgets/interactive-graph/— 44 tests pass, including 6 new vector scoring tests