[ Interactive Graph | Vector Graph ] PR2: State Management#3434
Open
SonicScrewdriver wants to merge 3 commits intoLEMS-3971/vector-pr1from
Open
[ Interactive Graph | Vector Graph ] PR2: State Management#3434SonicScrewdriver wants to merge 3 commits intoLEMS-3971/vector-pr1from
SonicScrewdriver wants to merge 3 commits intoLEMS-3971/vector-pr1from
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (68ae5c4) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3434If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3434If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3434 |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +88 B (+0.02%) Total Size: 495 kB
ℹ️ View Unchanged
|
cd4b7ce to
68ae5c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR was created with the help of AI, albeit with heavy oversight and review.
This is part of a series of PRs implementing the vector graph type for the Interactive Graph widget:
PR1 – type definitions and schema
▶️ PR2 – state management (this PR)
PR3 – rendering & accessibility
PR4 – scoring
PR5 – editor support
Issue: LEMS-3971
Changes:
vector: { moveTip, moveVector }to the actions object.moveTipdispatchesmovePoint(1, destination)for the tip (the only draggable point).moveVectordispatchesmoveLine(0, delta)for body translation.case "vector". Adds and exportsgetVectorCoords()with the standard three-path fallback: explicit coords → startCoords → normalized defaults. Default is a horizontal vector from [-5, 0] to [5, 0].doMovePoint(snap to grid, enforce bounds, reject if tip would overlap with tail). Adds"vector"to the existingdoMoveLinecase alongside"linear"/"ray"for body translation.getGradableGraph()branch for vector (coords passthrough, same shape as ray).withVector()builder method andVectorGraphConfigclass (matchesRayGraphConfigpattern).generateIGVectorGraph()generator function (new pattern, replacing builder long-term).generateIGVectorGraph.getVectorCoords.vectorQuestionandvectorQuestionWithDefaultCorrecttest fixtures.Test plan:
pnpm tsc— no new type errorspnpm test packages/perseus/src/widgets/interactive-graphs/reducer/— 143 tests pass, including 9 new vector tests: