Update GitHub action message for schema change to include release order info#3418
Update GitHub action message for schema change to include release order info#3418
Conversation
… for schema change to include release order info
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
github-actions
bot
added
the
schema-change
🗄️ Schema Change: No Changes ✅ |
There was a problem hiding this comment.
This is temporary change, to trigger the PR comment for schema change. Will remove this before landing the PR.
🛠️ Item Splitting: No Changes ✅ |
|
Size Change: 0 B Total Size: 494 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Added "Follow these steps on how to release." to make it simple but actionable, instead of adding the actual steps which makes the comment longer and it can mismatch the info in the future if there are any updates in the steps.
|
github-actions
bot
removed
the
schema-change
npm Snapshot: NOT PublishedOh noes!! We couldn't find any changesets in this PR (703f113). As a result, we did not |
jeremywiebe
left a comment
jeremywiebe
left a comment
There was a problem hiding this comment.
Thanks for improving this messaging!!
| This PR contains critical changes to Perseus. | ||
| Please review the changes and note that you may need to | ||
| coordinate deployment of these changes with other teams | ||
| at Khan Academy, especially with #cp-eng to publish a | ||
| content update. |
There was a problem hiding this comment.
| This PR contains critical changes to Perseus. | |
| Please review the changes and note that you may need to | |
| coordinate deployment of these changes with other teams | |
| at Khan Academy, especially with #cp-eng to publish a | |
| content update. | |
| This PR contains critical changes to Perseus that affect published data. | |
| Please review the changes and note that you may need to | |
| coordinate deployment of these changes with other teams | |
| at Khan Academy, especially with #cp-eng to publish a | |
| content update. |
"...content update." - I'm not totally sure I agree. Changes to the schema will affect published content after updating the publish worker, but the coordination with CP is around updating the publish worker, not updating content.
|
|
||
| **Usually this means you need to update the Go parser | ||
| that Content Platform maintains!!!** | ||
| **Usually this means you need to update the Go parser that Content Platform maintains!!!** |
There was a problem hiding this comment.
nit: these lines were broken at the 80-char guide. Can we revert this joining here? (not everyone has soft-wrap turned on).
| **Usually this means you need to update the Go parser that Content Platform maintains!!!** | |
| **Usually this means you need to update the Go parser | |
| that Content Platform maintains!!!** |
4 participants
Summary:
Update GitHub action message for schema change to include release order info.
By adding a more clear information in the message this give the engineer an actionalble item by referring to the guide and order of release. And we don't forget to collaborate with #cp-eng to do publish update so we don't cause any error or break prod with these types.
Issue: LEMS-4022
Test plan: