Repository navigation
Camera: move to @vyui/camera - #3
Merged
Merged
Conversation
The camera package is on npm now, so the file: dependency on app/vendor/kealanau-lynx-camera-0.1.0-alpha.0.tgz goes away along with the tarball itself. capturePhoto and pickPhoto now pass includeBase64 explicitly: the new package defaults it off, where the old one always returned base64 — without this every capture fails on "Camera returned no image data". pickFromLibrary drops its raw NativeModules workaround for adapter.pickPhoto. iOS host: the natives compile from node_modules/@vyui/camera/ios instead of a sibling lynx-camera checkout that no longer exists, and the deployment target moves to iOS 15 to match the package's podspec (saveToLibrary uses the iOS 14+ PHPhotoLibrary.requestAuthorization(for:)). The font entry needed an explicit group: XcodeGen nested it under the node_modules tree and doubled its path.
KealanAU
marked this pull request as ready for review
July 25, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the vendored
@kealanau/lynx-cameratarball for@vyui/camera@0.0.2off npm.app/vendor/tarball and itsfile:dependency deleted; workspace release-age exclude updatedcapturePhoto/pickPhotonow passincludeBase64explicitly — the new package defaults it off, the old one always returned base64pickFromLibraryusesadapter.pickPhotoinstead of pokingNativeModulesdirectlynode_modules/@vyui/camera/ios(the old path pointed at a sibling checkout that no longer exists)saveToLibraryuses iOS 14+PHPhotoLibrary.requestAuthorization(for:))group:— XcodeGen was nesting it under thenode_modulestree and doubling its pathNative side needs
xcodegen generate+pod installinapp/native/ios-host(already run locally).