Repository navigation
Create layer_2_semantic collection and warn on unknown vector collect… - #265
Merged
pradeeban merged 1 commit intoOct 18, 2026
Merged
Conversation
Contributor
|
Thanks for working on this. I fetched the branch and ran it: the 3 new tests pass, the full suite passes (352 passed, 1 skipped), and the CI flake8 gate is clean. It matches what I tried on my side. Small things:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247
VectorStorenow creates thelayer_2_semanticcollection (Chroma namepipeline_layer_2_semantic), so the location embedding thatingestion/routes.pyalready pushes there is actually stored.store_vector()now logs a warning when the collection name isn't registered. It still returnsFalse, so callers behave as before. A missing client still returnsFalsequietly.Notes
layer_2_semantic, as discussed on the issue.Tests
New
tests/test_vector_store.py, using a temporary persist directory so it doesn't touch./data/chroma_db:layer_2_semanticcollection is createdstore_vectorreturnsTrueFalse