Repository navigation
Return 400 for an invalid timestamp in /api/upload before saving the image - #256
Merged
pradeeban merged 1 commit intoOct 18, 2026
Merged
Conversation
An unparseable timestamp raised ValueError inside the pipeline, which returned a 500 and left the already-saved image in the upload folder. Validate it right after the required-field check and return 400, and add a test.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254
POST /api/uploadaccepted anytimestampstring. An invalid value such asyesterdayonly failed later inDreamsPipeline.process_new_post(datetime.fromisoformat). That produced a 500 and left the already-saved image in the upload folder.Change
In
dreams_app/app/ingestion/routes.py, the timestamp is now checked withdatetime.fromisoformatright after the required-field check. An invalid value returns400 {"error": "Invalid timestamp, expected ISO 8601"}before anything is written. The new testtests/test_upload_timestamp.pyposts an invalid timestamp and checks for a 400, an empty upload folder, and that the pipeline was never called.The check uses the same parser as the pipeline, so accepted formats don't change. Timestamps with or without an offset, and the default (now), still pass validation.
Testing
tests/test_places365_classifier.py, which needs torchvision, in my environment.AI assistance was used for this change; the tests were run before submitting.