Repository navigation
Don't crash login for a user without a password_hash - #252
Merged
pradeeban merged 1 commit intoOct 17, 2026
Merged
Conversation
check_password_hash(None, ...) raised AttributeError and login ended in a 500. Return False from User.check_password when there is no hash, and add a test.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user document has no password_hash, User.check_password calls check_password_hash(None, ...), which raises AttributeError, and login ends in a 500.
Change: check_password in dreams_app/app/models.py returns False when there’s no hash, so the user sees the normal “Invalid username or password”. I added a test in tests/test_auth.py.