Added password security level with a bar.#182
Added password security level with a bar.#182Shagufta08 wants to merge 1 commit intoKamandPrompt:masterfrom
Conversation
add password security level
Signior-X
left a comment
Signior-X
left a comment
There was a problem hiding this comment.
Awesome work done, the feature was working good and it's great!
Just you need to better format the code, which I think the editor you are using will help!
| display: flex; | ||
| position: relative; | ||
| } | ||
| form .password-wrapper .password{ |
There was a problem hiding this comment.
Nice work, it will be better if you add a single line after the ending of each css block
| @@ -0,0 +1,59 @@ | |||
| const indicator = document.querySelector(".indicator"); | |||
There was a problem hiding this comment.
Use a better name for classes so that it doesn't conflict with some other variables in future.
like instead of indicator use pass-security-indicator
| if(input.value != ""){ | ||
| indicator.style.display = "block"; | ||
| indicator.style.display = "flex"; | ||
| if(input.value.length <= 3 && (input.value.match(regExpWeak) || input.value.match(regExpMedium) || input.value.match(regExpStrong)))no=1; |
There was a problem hiding this comment.
Make this code a bit better readable, like you can do one thing.
If you are using VScode, simply select the whole filea and right click and format it.
It would be better with some spaces and line breaks
| input.type = "text"; | ||
| showBtn.textContent = "HIDE"; | ||
| showBtn.style.color = "#23ad5c"; | ||
| }else{ |
There was a problem hiding this comment.
Same as above, proper formatting is just needed.
Right-click and format the file, so there is a consistency in spacing and tabs.
|
|
||
| <div class="password-wrapper"> | ||
| <label for="inputPasswordSignUp" class="sr-only">Password</label> | ||
| <input class="form-control password" type="password" onkeyup="trigger()" name="password" id="inputPasswordSignUp" placeholder="Password" required> |
|
Thanks! |
2 participants
Added 2 files,i.e. passwordindicator.css ,passwordindicator.js, and made changes in header.ejs
Issue #81
[add password security level]
Fixes: #81