Skip to content

Pharma - Change advanced treatments to use Medication function instead of duplicating it - #839

Open
NikkoJT wants to merge 1 commit into
KAT-Advanced-Medical:dev-Tomcatfrom
NikkoJT:treatment-displaynames-in-log
Open

Pharma - Change advanced treatments to use Medication function instead of duplicating it#839
NikkoJT wants to merge 1 commit into
KAT-Advanced-Medical:dev-Tomcatfrom
NikkoJT:treatment-displaynames-in-log

Conversation

@NikkoJT

@NikkoJT NikkoJT commented Jul 26, 2026

Copy link
Copy Markdown

When merged this pull request will:

  • Change several advanced treatment functions to use the Medication function, instead of duplicating its code
  • Aside from reducing code duplication, this also makes these treatments use the item's displayname for log entries again, instead of using the treatment action's classname. This is better because the displayname is meant to be shown in UI text and the treatment action classname is not (e.g. may contain addon prefixes, cannot contain spaces).
  • Note: the Penthrox advanced treatment is basically redundant, because its code is literally just the Medication function, but I didn't outright remove it because that's a bigger change and it may be used for something later.

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant